Improve PWA internal/external URL routing controls#813
Open
djangonavarro220 wants to merge 5 commits into
Open
Improve PWA internal/external URL routing controls#813djangonavarro220 wants to merge 5 commits into
djangonavarro220 wants to merge 5 commits into
Conversation
0b2b579 to
bed3953
Compare
bed3953 to
8d2641c
Compare
Owner
|
Can you please also set up translations? Some guidelines how the translation system works are here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves how PWAs decide whether a URL should stay inside the app window or open in the regular browser.
What changed
https://mail.google.com/mail/https://*.google.com/*https://domain.com/path/*Why
There are several long-running reports around:
_blank/ new-window links staying inside the PWAThis PR aims to improve the common case without requiring manual configuration for every app, while still allowing finer per-app control when needed.
Related to:
target="_blank"links in the default browser #354openOutOfScopeInDefaultBrowser#383Notes