Repository navigation
feat(opaque-links): recognise 0x link ids (TEC-3037) - #34
Merged
Merged
Conversation
Opaque link ids are now 0x plus 18 base58 characters, a product requirement. Rooms are matched by that exact shape, never by the 0x prefix alone, since addresses, hashes and on-chain ids also start with 0x. - acceptedDdocId stores the on-chain ddocId only for a room named by a link id, and refuses a link id as the ddocId. - The publish reconciler skips link rooms that have no ddocId. - Tests cover link ids, the old o- shape, address-named rooms and on-chain ids that start with 0x. Deploy before any ddocs.new that mints 0x ids, or no ddocId is stored for new opaque rooms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opaque link ids are now 0x plus 18 base58 characters, a product requirement. Rooms are matched by that exact shape, never by the 0x prefix alone, since addresses, hashes and on-chain ids also start with 0x.
Deploy before any ddocs.new that mints 0x ids, or no ddocId is stored for new opaque rooms.