Repository navigation
fix(chronos): make bun dev start on Windows - #456
Merged
Merged
Conversation
…Windows
`bun dev` passed `--max-http-header-size=${CHRONOS_MAX_HTTP_HEADER_SIZE:-65536}`,
which Windows' Bun Shell cannot expand, so the literal placeholder reached bun
and the app exited with "Invalid value for --max-http-header-size". Bun also
accepts the cap through node:http's `maxHeaderSize` accessor, so the API now
sets it from CHRONOS_MAX_HTTP_HEADER_SIZE at startup and the dev script goes
back to plain `bun run --hot src/index.ts`. An empty value still defaults to
65536; the image entrypoint keeps passing the flag as a launch-level default.
merenyimiklos
marked this pull request as ready for review
November 12, 2026 21:49
merenyimiklos
self-requested a review
November 12, 2026 21:49
🗑️ Preview removed
Posted by filc-deployer. The preview database is its own container and is |
merenyimiklos
approved these changes
Nov 12, 2026
Contributor
|
mehet a menet |
merenyimiklos
added
chronos - backend
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows,
bun devshut down as soon as it reached the backend: the start-up command asked the shell for an optional setting, and the Windows shell doesn't understand that syntax, so the backend got garbage instead of a number and refused to start. Nothing on Windows could run the app in development.Now the backend works that setting out itself, so the start-up command is plain text that behaves the same on Windows, Linux and macOS.
Changes
bun run --hot src/index.ts.CHRONOS_MAX_HTTP_HEADER_SIZEstill overrides it; leaving it empty keeps the current 65536. A bad value now stops the app with a clear message..env.exampleupdated; the Docker start-up command is unchanged.Verification
bun run lintbun run typecheckbun run build— if bundler config, routers, or server entrypoints changed