fix: harden v1 lease recovery#44
Merged
ferueda merged 3 commits intoJun 12, 2026
Merged
Conversation
ferueda
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diagnostics.failedPhaseinstead of relying on hook error message prefixes.postCreateduringresume-acquirewhen the failed pending acquire did not complete its creation hook, and coverpreReleasereplay duringresume-cleanup.--reuse-existing-branchas the opt-in path; document repair-time branch reuse semantics.Review follow-up
Addressed review nits from the approve-with-nits pass:
postCreatereplay heuristic with structuredfailedPhase.resume-cleanupafterpreReleasehook failure regression.postAcquirenon-quarantine behavior.err: anycatches inpool.tsandgit/branch.ts.Verification
pnpm lintpnpm buildpnpm typecheckpnpm exec vitest run packages/grove/test/transitions.test.ts packages/grove/test/lease.integration.test.ts -t "structured|postCreate|preRelease|reset release returns a clean slot" --reporter=verbosepnpm exec vitest run --reporter=verbose(12 files, 145 tests passed)Note: direct push to
ferueda/groveis not available to the active GitHub account, so this PR is opened from thefrueda-godaddy/grovefork.