feat: v1 lease release with ReleaseResult (PR 3)#34
Merged
Conversation
Add lease-release module with WAL pendingCleanup for all policies, typed release results, cleanIgnored reset support, and repair resume-cleanup from quarantine.
Re-check process safety after preRelease before reset cleanup, and return LEASE_BUSY or LEASE_QUARANTINED instead of LEASE_NOT_FOUND for busy leases.
Unify hook env via buildLeaseHookEnv, move enrichLeaseReadOnly outside the state lock, and tighten release safety and CLI narrowing. Plan doc records deferred dedup refactors for PR 4 destroy work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resume-cleanup):ReleaseResultdiscriminated union, WAL release for all cleanup policies, andrepair({ action: "resume-cleanup" }).lease-release.tsdrives preserve/reset/quarantine through transitions (RELEASE_START,RELEASE_PRESERVE_COMPLETE,RELEASE_RESET_COMPLETE,RELEASE_FAILED).git reset --hard, andgit clean -fd(or-fdxwithcleanIgnored: true); failed reset quarantines lease + slot withpendingCleanuppreserved.Test plan
pnpm check(141 tests)leased, reacquire worksavailable, untracked removedcleanIgnored: trueremoves itquarantinedresultresume-cleanupcompletes interrupted preserve WALpendingCleanup(existing repair test)Stack
Targets
feat/lease-first-v1. PR 4 next: destroy MVP.