Conversation
Gaic4o
marked this pull request as ready for review
September 2, 2026 14:41
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Solant
reviewed
Sep 6, 2026
Contributor
There was a problem hiding this comment.
We can use the FSD-approved way of doing ambient imports: https://fsd.how/docs/guides/examples/types/#ambient-declaration-files-dts
P.S. I'm not 100% fond of the name like untyped-packages, as it might create very long paths. (Maybe something like “typings” might be enough, but I'm fine with any folder name.)
| Edit page | ||
| </a> | ||
| )} | ||
| <a href={requestUrl} class="print:hidden"> |
Contributor
There was a problem hiding this comment.
do you think we need target="_blank" there?
| !isSplash && ( | ||
| <> | ||
| {editUrl && ( | ||
| <a href={editUrl} class="print:hidden"> |
Contributor
There was a problem hiding this comment.
- Do you think we need target="_blank" there?
- How is it going to work with someone who has no write access to the repository? From what I can see, the button there is to commit directly into master (which even we can't do)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
I created this PR to address #256.
At first, I considered closing the issue as
Not Planned, but I thought it could still be useful to give readers of the official documentation a more approachable way to suggest topics they would like to see covered.There are already several channels where people can leave feedback, such as Issues, Discussions, and the community, but I thought having an entry point directly within the documentation could make it a bit easier for readers to naturally turn those thoughts into documentation requests.
So I added
Edit pageandRequest an articlelinks to the bottom of documentation pages.Request an articlelinks to theIdeascategory in Discussions, where documentation-related ideas are already being shared.Originally, I wanted to discuss the direction with Solant, who usually reviews these changes, before working on the UI. Since Solant is currently on vacation and the scope of the change is relatively small, I went ahead and put together a quick proposal first. If there is a better way to approach this through Issues or Discussions, I would be happy to discuss it in #256 and adjust the implementation accordingly.
I see this as a small UI addition that provides readers with a slightly easier way to participate in improving the documentation without significantly changing the existing documentation flow.