Skip to content

fix: don't activate default im when switch focus within app #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eagleoflqj merged 2 commits into from
May 13, 2026
Merged

fix: don't activate default im when switch focus within app #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd6d84d
fix: don't activate default im when switch focus within app
eagleoflqj May 13, 2026
32d13a2
fix review comments
eagleoflqj May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion macosfrontend/macosfrontend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,9 +287,14 @@ void MacosFrontend::focusIn(ICUUID uuid, bool isPassword) {
auto program = ic->program();
FCITX_INFO() << "Focus in " << program;
if (!program.empty()) {
useAppDefaultIM(program);
// Focusing on another input field in the same app shouldn't activate
// default IM.
if (program != lastFocusedApp_) {
useAppDefaultIM(program);
}
useVimMode(program, ic);
Comment thread
eagleoflqj marked this conversation as resolved.
}
lastFocusedApp_ = program;
}

std::string MacosFrontend::commitComposition(ICUUID uuid) {
Expand Down
1 change: 1 addition & 0 deletions macosfrontend/macosfrontend.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ class MacosFrontend : public AddonInstance {
eventHandlers_;
std::string statusItemText;
std::unordered_map<std::string, std::string> appDefaultIMCache_;
std::string lastFocusedApp_;
void updateStatusItemText();

inline MacosInputContext *findIC(ICUUID);
Expand Down
Loading