Use of modern C++ practices and CMake#4
Merged
Conversation
Owner
|
First of all |
favorart
reviewed
May 27, 2025
favorart
reviewed
May 27, 2025
favorart
reviewed
May 27, 2025
favorart
reviewed
May 27, 2025
favorart
reviewed
May 27, 2025
favorart
reviewed
May 27, 2025
favorart
reviewed
May 27, 2025
favorart
force-pushed
the
master
branch
6 times, most recently
from
5899f1d to
000636f
Compare
Check compilation for all platforms and compilers
favorart
reviewed
May 29, 2025
| namespace utils { | ||
| namespace vcd::utils { | ||
| // ----------------------------- | ||
| std::string format(const char *fmt, ...) |
Owner
There was a problem hiding this comment.
With fmt, this function is no longer needed
favorart
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed some bits of the code to comply with the latest C++ standards (as of today C++23) and added a CMakeLists.txt file for a faster and easier integration of the produced library in other projects