auth/oidc: Add support for static JWKS and PEM key verification in OIDC#5260
auth/oidc: Add support for static JWKS and PEM key verification in OIDC#5260johnvox wants to merge 7 commits into
Conversation
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (1 file)
Fix these issues in Kilo Cloud Reviewed by gpt-5.5-2026-04-23 · 394,710 tokens |
|
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d of inactivity and eventually close. |
|
/not stale |
|
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d of inactivity and eventually close. |
|
/not stale |
|
Hi, NewTokenVerifierFromStatic can call DecodeJWKS with a nil *JSONWebKeySet, which dereferences jwks.Keys and panics, potentially crashing the server at startup when the dynamic provider lookup fails and static config is incomplete. Severity: action required | Category: reliability How to fix: Validate IssuerSpec and nil-check Agent prompt to fix - you can give this to your LLM of choice:
We noticed a couple of other issues in this PR as well - happy to share if helpful. Found by Qodo code review |
Handle Qodo-Free-For-OSS comment
WHY
This PR introduces support for static key verification in the OIDC authentication flow, allowing the use of JWKS (JSON Web Key Set) and PEM-encoded certificates/public keys as alternatives to dynamic OIDC provider-based verification.
Enables OIDC token verification in offline or restricted environments.
New Configuration:
Here Config Snippet used during dev