Skip to content

http1: return error if send_response returns incomplete #48373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkarneges merged 1 commit into from
Jun 22, 2026
+9 −5
Merged

http1: return error if send_response returns incomplete #48373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/core/http1/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,15 +436,19 @@ impl<'a, R: AsyncRead, W: AsyncWrite> Response<'a, R, W> {
let header_size = {
let mut buf = io::Cursor::new(inner.wbuf.write_buf());

if inner
match inner
.protocol
.send_response(&mut buf, code, reason, headers, body_size, 0)
.is_err()
{
// enable prepare_header to be called again
inner.wbuf.clear();
Ok(None) => {}
Ok(Some(_)) | Err(_) => {
// Partial write, or error due to input being too large

return Err(Error::ResponseTooLarge(size_limit));
// Enable prepare_header to be called again
inner.wbuf.clear();

return Err(Error::ResponseTooLarge(size_limit));
}
}

buf.position() as usize
Expand Down
Loading