Skip to content

ci(preview): switch trigger to pull_request to fix untrusted checkout - #496

Merged
Eomm merged 3 commits into
mainfrom
fix/preview-workflow-untrusted-checkout
Sep 14, 2026
Merged

Eomm merged 3 commits into
mainfrom
fix/preview-workflow-untrusted-checkout

Conversation

@ilteoood

@ilteoood ilteoood commented Aug 26, 2026 •

Copy link
Copy Markdown
Member

Description

Switches the trigger from pull_request_target to pull_request: branches: [main]. With the unprivileged trigger, the workflow no longer runs fork code in a context that holds NETLIFY_AUTH_TOKEN, which closes the CodeQL actions/untrusted-checkout/medium alert.

Related Issues

Closes https://github.com/fastify/website/security/code-scanning/32

Check List

Replaces pull_request_target with pull_request: branches: [main].
Removes the privileged context that allowed fork code to run npm
build scripts while holding NETLIFY_AUTH_TOKEN, addressing the
CodeQL actions/untrusted-checkout/medium alert.

Closes https://github.com/fastify/website/security/code-scanning/32
@ilteoood
ilteoood force-pushed the fix/preview-workflow-untrusted-checkout branch from 7bb94c1 to 0703e1f Compare August 26, 2026 10:41
@ilteoood ilteoood changed the title ci(preview): split build and deploy to fix pwn request vulnerability ci(preview): switch trigger to pull_request to fix untrusted checkout Aug 26, 2026
@ilteoood
ilteoood marked this pull request as ready for review September 11, 2026 19:20

@Eomm Eomm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems working!

@Eomm
Eomm merged commit 915d0aa into main Sep 14, 2026
5 of 6 checks passed
@Eomm
Eomm deleted the fix/preview-workflow-untrusted-checkout branch September 14, 2026 08:09

This branch was successfully deployed

2 active deployments
staging — 1da44f82 Deployed Sep 14, 2026 by Eomm via deploy-to-staging #181
sandbox — 1da44f82 Deployed Sep 14, 2026 by Eomm via build-and-upload #181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants