fix: use registered root for relative downloads - #610
Merged
Tony133 merged 2 commits intoSep 25, 2026
Merged
Conversation
Signed-off-by: lprnmns <manasalperen@gmail.com>
lprnmns
marked this pull request as ready for review
August 31, 2026 16:20
Signed-off-by: lprnmns <manasalperen@gmail.com>
ilteoood
self-requested a review
September 25, 2026 13:13
ilteoood
approved these changes
Sep 25, 2026
Tony133
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
@fastify/staticis registered with aroot,reply.download()returns a 404 for a relative file path such asreply.download('myHtml.html'). The README documents this relative form, and the equivalent relativereply.sendFile()call serves successfully; the download response still setsContent-Dispositionbefore failing.Fix
Use the registered plugin root when
download()is not given a per-call root, matching the existingsendFile()behavior. Explicit per-call roots continue to take precedence.Tests
node --test --test-name-pattern='download' test/static.test.js— passed; 10 tests. The same focused test failed on the new regression case before the fix.npm test— passed; 347 unit tests, 100% reported coverage, 20/20 TypeScript assertions.npm run lint— passed.npm run benchmark --if-present— passed; no benchmark script is defined.node --check index.js && node --check test/static.test.js— passed.git diff HEAD^ HEAD --check— passed.Compatibility
This only supplies the registration root when no per-call root is supplied. Existing absolute paths, explicit roots, options, and response headers remain unchanged. No dependencies or package versions were changed.
Related issue
Independent reproduction; no matching open issue or pull request was found.