docs: clarify multipart bodyLimit is not an aggregate limit - #645
Merged
Merged
Conversation
Multipart requests are parsed by a dedicated streaming parser and bypass Fastify's bodyLimit enforcement. bodyLimit is only used to derive the per-file fileSize default and is not applied as an aggregate limit across the whole multipart payload. Document this and recommend explicit fieldSize/fields/files/parts/fileSize limits. Ref: GHSA-3pm6-wjfr-3v47
Member
|
CI all green 🙌 ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document that
@fastify/multipartdoes not enforce Fastify's aggregatebodyLimitfor multipart requests.Multipart payloads are parsed by a dedicated streaming parser and bypass Fastify's
bodyLimitenforcement.bodyLimitis only used to compute the defaultfileSize; it is not enforced as an aggregate limit across the whole request. This is intentional (streaming) but was undocumented, and the old README text (fileSizedefaulting to 1048576) was misleading because that value only holds whenbodyLimitis the Fastify default.Changes
bodyLimitis not an aggregate limit and is not applied at the route level.limits.fileSizedefaults to the FastifybodyLimit.This is a documentation-only change, no runtime behavior.
Ref: GHSA-3pm6-wjfr-3v47