Regenerate the session before logging in as a new user - #170
Open
aaronofinn wants to merge 3 commits into
Open
aaronofinn wants to merge 3 commits into
aaronofinn wants to merge 3 commits into
Conversation
Member
|
We need this: fastify/session#348 |
Member
Done! see new release here: https://github.com/fastify/session/releases/tag/v11.1.3 🔥 👀 |
Member
|
@Tony133 Thx! |
Contributor
Author
|
@jean-michelet done, can you merge when ready? I don't have access |
|
| @@ -1,2 +1,3 @@ | |||
| ignore-scripts=true | |||
| min-release-age=7 | |||
| min-release-age-exclude=@fastify/session | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
auth/index.ts's login handler assignsrequest.session.user = {...}and callsrequest.session.save(), but never rotates the session ID. If a valid session cookie is already present when/loginis called,@fastify/sessionreuses that same ID, it just overwrites who the session belongs to.If an attacker could get a session ID they already know onto a victim's browser before the victim authenticates (however that happens), the ID staying the same across login means the attacker's foreknowledge of it remains useful after the victim logs in. Regenerating the session ID at the moment authentication state changes is the standard defense, it invalidates whatever ID existed beforehand.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct