Add sameSite: 'lax' to cookie settings - #169
Merged
jean-michelet merged 2 commits intoSep 14, 2026
Merged
Conversation
|
Member
That's Strict, not Lax. I planed to introduce CSRF building a SPA, but I always failed to fastify/vite with React. |
jean-michelet
approved these changes
Sep 14, 2026
Contributor
Author
|
@jean-michelet would you mind merging? I don't have priveleges for some reason |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
session.tssetssecureandhttpOnlyon the session cookie but neversameSiteand there's no CSRF token mechanism anywhere in the app either. Whatever protection exists today is Chrome's own implicit default (treating a missingSameSiteasLax), an accident of the browser, not something this app's config actually asserts, and not something every client is guaranteed to apply consistently.Adding sameSite: 'lax' to the cookie settings allows us to explicitly enforce that the session cookie is only sent on same-site requests, rather than depending on whichever browser happens to be in use applying its own undocumented default when the attribute is missing.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct