Add optional swapToken display hints for prominent token cost in host UI#602
Draft
neynar-chatbot-agent wants to merge 1 commit into
Draft
Add optional swapToken display hints for prominent token cost in host UI#602neynar-chatbot-agent wants to merge 1 commit into
neynar-chatbot-agent wants to merge 1 commit into
Conversation
Optional display.headline and display.subline on swapToken options let mini apps pass human-readable cost context for host swap sheets while sellAmount stays the on-chain source of truth. Documented in swap-token SDK page with example.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 95301fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User feedback (NEYN-10665) asked for a more prominent display of token cost during mini app swap flows (e.g. word-a-day requiring 5,000,000 tokens). This repository defines the mini app SDK contract; the Farcaster client renders the swap sheet.
Changes
SwapTokenOptionsin@farcaster/miniapp-corewith optionaldisplay?: { headline?: string; subline?: string }so mini apps can pass human-readable copy the host can show prominently (formatted totals, “required to participate”, etc.).sellAmountremains the source of truth for the transaction.Follow-up (outside this repo)
Host / miniapp-host client implementations should read
display.headlineanddisplay.sublinewhen present and render them prominently in the swap confirmation UI. The word-a-day app should pass e.g.display: { headline: "5,000,000 tokens", subline: "Required to participate" }alongsidesellAmount.Testing
pnpm --filter @farcaster/miniapp-core typecheckpnpm checkLinear Issue: NEYN-10665