fix(miniapp-core): usernameSchema for ENS-style Farcaster names (NEYN-10523)#596
Draft
neynar-chatbot-agent wants to merge 1 commit into
Draft
fix(miniapp-core): usernameSchema for ENS-style Farcaster names (NEYN-10523)#596neynar-chatbot-agent wants to merge 1 commit into
neynar-chatbot-agent wants to merge 1 commit into
Conversation
Expose a shared Zod schema that accepts fName-style usernames and dotted ENS names (e.g. *.eth, *.base.eth) using the same label rules as domainSchema. Add tests for alphacaster.base.eth and related cases (NEYN-10523).
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
usernameSchemain@farcaster/miniapp-coreso sign-in and other flows can validate Farcaster identities that use ENS-style names with dots (for example*.ethand*.base.eth), not only fName-style identifiers.Details
DOMAIN_REGEXrules asdomainSchema, so labels follow normal domain constraints (no.., valid TLD length, etc.).Tests
alphacaster.eth,alphacaster.base.eth, and invalid cases.Linear: NEYN-10523
Linear Issue: NEYN-10523