fix(NEYN-10434): backward-compat openSnap → openMiniApp in host/SDK#593
Draft
neynar-chatbot-agent wants to merge 1 commit into
Draft
fix(NEYN-10434): backward-compat openSnap → openMiniApp in host/SDK#593neynar-chatbot-agent wants to merge 1 commit into
neynar-chatbot-agent wants to merge 1 commit into
Conversation
Wire path openSnap matches the Frames SDK open_snap action used by older mini apps. Forward it to openMiniApp in the host, expose the same alias on WireMiniAppHost and sdk.actions, and add actions.openSnap to the capability list for manifest validation.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves NEYN-10434: legacy Frames
open_snapactions (wired over Comlink asopenSnap) were rejected by the mini app host because onlyopenMiniAppwas handled, so clicks did nothing.Changes
packages/miniapp-host/src/comlink/comlink.ts: handleopenSnapAPPLY messages by delegating to the same implementation asopenMiniApp.packages/miniapp-host/src/helpers/sdk.ts: exposeopenSnapon the wire host as an alias ofopenMiniApp.packages/miniapp-sdk/src/sdk.ts/types.ts: addactions.openSnapas an alias ofopenMiniAppfor explicit SDK use.packages/miniapp-core/src/types.ts: extendWireMiniAppHostwithopenSnapand addactions.openSnaptominiAppHostCapabilityListso manifests can require the legacy capability path.Testing
pnpm --filter @farcaster/miniapp-core buildpnpm --filter @farcaster/miniapp-host --filter @farcaster/miniapp-sdk typecheckpnpm --filter @farcaster/miniapp-core testpnpm biome checkon touched filesLinear Issue: NEYN-10434