feat(miniapp-sdk): add addToSidebar action (alias for addMiniApp)#591
Draft
lyoshenka wants to merge 1 commit into
Draft
feat(miniapp-sdk): add addToSidebar action (alias for addMiniApp)#591lyoshenka wants to merge 1 commit into
lyoshenka wants to merge 1 commit into
Conversation
Expose sdk.actions.addToSidebar as an alias for the existing add flow, add actions.addToSidebar to the capability list, and mirror it in getCapabilities when the host reports addMiniApp. Document the action on the docs site.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements NEYN-10365 by exposing
sdk.actions.addToSidebar()as an alias for the existing “add this Mini App” flow (addMiniApp/ legacyaddFrame). No new host RPC is required.Changes
sdk.actions.addToSidebar— same implementation and errors asaddMiniApp.actions.addToSidebaradded tominiAppHostCapabilityListin@farcaster/miniapp-coreso manifests can declarerequiredCapabilitieswith this name.sdk.getCapabilities()— when the host returnsactions.addMiniAppbut notactions.addToSidebar, the SDK appendsactions.addToSidebarso capability checks stay consistent.addMiniApppage.Testing
pnpm typecheck --filter=@farcaster/miniapp-sdk --filter=@farcaster/miniapp-corepnpm check(Biome) ran on commitLinear Issue: NEYN-10365