fix: disable storage on ENS fallback config#509
Open
tenderdeve wants to merge 1 commit into
Open
Conversation
The internal ENS fallback config used createConfig without disabling storage, causing it to write to localStorage under the default "wagmi.store" key. This conflicts with applications that use a custom storage key, leading to chain state reverting to mainnet on page reload. Setting storage: null prevents the fallback config from persisting any state since it is only used for read-only ENS resolution. Fixes family#479
|
@tenderdeve is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal ENS fallback config creates a separate Wagmi instance that writes to localStorage under the default "wagmi.store" key. When the host app uses a custom storage key, both keys coexist and the fallback config overrides the user's chain selection on page reload.
Setting
storage: nullon the fallback config prevents it from persisting any state, which is correct since it only exists for read-only ENS resolution on mainnet.Fixes #479