Repository navigation
fix(sdk-java): resolve Gradle plugin dependencies from Maven Central first - #2822
Merged
Merged
Conversation
…first The v0.52.0 Maven Central publish failed configuring the build: the plugin portal served converter-moshi's POM but not its jar, and Gradle does not try another repository for an artifact once one has served its metadata. Plugin dependencies now come from Maven Central; the portal serves only what it alone has (plugin markers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.52.0 Publish Maven Central job failed while configuring the Java SDK build, before anything was uploaded:
The jar answers 200 there now, so the portal miss was transient. Plugin resolution used only the plugin portal, and Gradle does not try another repository for an artifact once one has served its metadata, so adding a fallback after the portal would not help.
pluginManagementnow lists Maven Central first: the publish plugin's dependencies (retrofit, moshi, okhttp, ...) come from Central, and the portal serves only what it alone has, such as plugin marker artifacts.The v0.52.0 tag is frozen; its Maven Central job is re-run separately.
Test plan
./gradlew --refresh-dependencies buildEnvironmentresolves the plugin tree from a cold cache;compileJavapasses;publishToMavenCentralis still configured.sdksJava job (./gradlew build).Summary by cubic
Fixes the v0.52.0 Maven Central publish job, which failed when the Gradle plugin portal served converter-moshi's POM but not its jar.
pluginManagementnow resolves plugin dependencies from Maven Central first and falls back to the plugin portal only for artifacts it alone has, like plugin markers. The v0.52.0 tag is frozen, so its Maven Central job is re-run separately.Written for commit 1f6947a. Summary will update on new commits.