feat(nimble): Add top-level column index projection to Deserializer (#1017) - #1017
Open
duxiao1212 wants to merge 1 commit into
Open
duxiao1212 wants to merge 1 commit into
duxiao1212 wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@duxiao1212 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113589956. |
meta-codesync
Bot
changed the title
duxiao1212
force-pushed
the
export-D113589956
branch
from
July 27, 2026 16:05
f38c4d0 to
9741d8b
Compare
duxiao1212
added a commit
to duxiao1212/nimble
that referenced
this pull request
Jul 27, 2026
…acebookincubator#1017) Summary: Added the named factory createForTopLevelColumns to support Nimble deserialization using numeric top-level column indices instead of field names. `Deserializer::createForTopLevelColumns`, which accepts zero-based Velox top-level column indices. Output ordering therefore remains unchanged and follows the existing lexicographical-by-field- name contract. Reviewed By: xiaoxmeng Differential Revision: D113589956
…acebookincubator#1017) Summary: Added the named factory createForTopLevelColumns to support Nimble deserialization using numeric top-level column indices instead of field names. `Deserializer::createForSelectedColumns`, which accepts zero-based Velox top-level column indices. Output ordering therefore remains unchanged and follows the existing lexicographical-by-field- name contract. Reviewed By: xiaoxmeng Differential Revision: D113589956
duxiao1212
force-pushed
the
export-D113589956
branch
from
July 27, 2026 17:00
9741d8b to
49b814c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Added the named factory createForTopLevelColumns to support Nimble deserialization using numeric top-level column indices instead of field names.
Deserializer::createForSelectedColumns, which accepts zero-based Velox top-level column indices. Output ordering therefore remains unchanged and follows the existing lexicographical-by-field- name contract.Reviewed By: xiaoxmeng
Differential Revision: D113589956