Skip to content

Allow arbitrary number of skinning weights - Updated#247

Closed
fire wants to merge 1 commit into
facebookincubator:masterfrom
godotengine:skinning_weights
Closed

Allow arbitrary number of skinning weights - Updated#247
fire wants to merge 1 commit into
facebookincubator:masterfrom
godotengine:skinning_weights

Conversation

@fire

@fire fire commented Dec 25, 2019

Copy link
Copy Markdown

Controlled through command line parameter. Defaults to 4 skinning weights.

Update of #205

@facebook-github-bot

Copy link
Copy Markdown

Hi fire! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@fire fire changed the title Allow arbitrary number of skinning weights. Allow arbitrary number of skinning weights - Updated Dec 25, 2019
@fire

fire commented Dec 25, 2019

Copy link
Copy Markdown
Author

Need to wait until the end of the Holidays to confirm the CLA.

@fire

fire commented Dec 25, 2019

Copy link
Copy Markdown
Author

@etherlore Here is the branch as a pull request.

Comment thread src/fbx/Fbx2Raw.cpp Outdated

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a crash when there's no skin here. @etherlore

Controlled through command line parameter. Defaults to 4 skinning weights.
@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@fire

fire commented Jan 2, 2020

Copy link
Copy Markdown
Author

@zellski Can you review this?

@fire fire requested a review from zellski January 27, 2020 19:57
@fire fire closed this Jun 6, 2021
@fire fire deleted the skinning_weights branch June 6, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants