Skip to content

[eslint-plugin] Skip single-value gridArea in valid-shorthands #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henryqdineen wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −29
Open

[eslint-plugin] Skip single-value gridArea in valid-shorthands #1737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 11 additions & 28 deletions packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-shorthands-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,17 @@ eslintTester.run('stylex-valid-shorthands', rule.default, {
})
`,
},
// grid-area: single-value custom-ident
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
gridArea: 'header',
},
})
`,
},
// Already-longhand grid properties
{
code: `
Expand Down Expand Up @@ -1532,34 +1543,6 @@ eslintTester.run('stylex-valid-shorthands', rule.default, {
},
],
},
// grid-area: custom-ident expands to 4 longhands
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
gridArea: 'header',
},
});
`,
output: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
main: {
gridColumnEnd: 'header',
gridColumnStart: 'header',
gridRowEnd: 'header',
gridRowStart: 'header',
},
});
`,
errors: [
{
message:
'Property shorthands using multiple values like "gridArea: header" are not supported in StyleX. Separate into individual properties.',
},
],
},
// grid-area: custom-ident with 2 slash-separated parts
{
code: `
Expand Down
2 changes: 1 addition & 1 deletion packages/@stylexjs/eslint-plugin/src/stylex-valid-shorthands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ const stylexValidShorthands = {
return;
}

if (key === 'flex' && isSingleToken(String(v))) {
if ((key === 'flex' || key === 'gridArea') && isSingleToken(String(v))) {
return;
}

Expand Down
Loading