[eslint-plugin] Fix single-value background: foo shorthand silently dropped — add lint error with autofix#1736
Open
alvinbillian wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
background: foo shorthand silently dropped — add lint error with autofix
background: foo shorthand silently dropped — add lint error with autofixbackground: foo shorthand silently dropped — add lint error with autofix
background: foo shorthand silently dropped — add lint error with autofixbackground: foo shorthand silently dropped — add lint error with autofix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Single-value background shorthand like this:
is compiled without any linter warnings but produced no
background: redstyle, ommitting that style entirely, giving false-positive result. (Reproduction in StyleX Playground)The compiler requires the longhand syntaxes, e.g.
background-color: redorbackground-image: url(image.jpg)instead.Multi-token values like background: 'red no-repeat' are already caught by the linter:
What changed in the fix
The shorthand splitter already contains a full background token classifier that can identify colors, images, repeat keywords, attachment keywords, and position keywords. The fix routes single-token background values through this existing classifier instead of short-circuiting past it, so they are expanded to the correct longhand and flagged with an autofix.
One special case:
In CSS, global keywords (
inherit,initial,unset,revert,revert-layer) on the background shorthand apply to all sub-properties simultaneously:There is no safe single-longhand expansion for this. Therefore, these are flagged as errors but with no autofix, leaving the developer to decide which specific longhands to set.
Added test cases
Example cases
Before (silent failure):
After (lint error):
After (autofix applied):
Pre-flight checklist
Contribution Guidelines