Skip to content

[eslint-plugin] valid-styles support for scroll timeline & webkit app region #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skovhus wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Open

[eslint-plugin] valid-styles support for scroll timeline & webkit app region #1699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-styles-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,15 @@ eslintTester.run('stylex-valid-styles', rule.default, {
'containIntrinsicSize': 'auto 300px',
},
})`,
`import * as stylex from '@stylexjs/stylex';
stylex.create({
default: {
scrollTimeline: '--main-scroll block',
scrollTimelineAxis: 'inline',
scrollTimelineName: '--main-scroll',
WebkitAppRegion: 'drag',
},
})`,
`import * as stylex from '@stylexjs/stylex';
stylex.create({
a: {
Expand Down
9 changes: 9 additions & 0 deletions packages/@stylexjs/eslint-plugin/src/reference/cssProperties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,6 +1183,12 @@ const scrollSnapType: RuleCheck = makeUnionRule(
makeLiteralRule('x mandatory'),
makeLiteralRule('y mandatory'),
);
const scrollTimelineAxis: RuleCheck = makeUnionRule(
makeLiteralRule('block'),
makeLiteralRule('inline'),
makeLiteralRule('x'),
makeLiteralRule('y'),
);
const shapeImageThreshold: RuleCheck = isStringOrNumber;
const shapeOutside: RuleCheck = makeUnionRule(
makeLiteralRule('none'),
Expand Down Expand Up @@ -2161,6 +2167,9 @@ const CSSProperties = {
scrollSnapAlign: scrollSnapAlign,
scrollSnapType: scrollSnapType,
scrollSnapStop: makeUnionRule('normal', 'always') as RuleCheck,
scrollTimeline: isString,
scrollTimelineAxis: scrollTimelineAxis,
scrollTimelineName: isString,

// scrollMargin: makeUnionRule(isNumber, isString),
scrollMarginBlockEnd: makeUnionRule(isNumber, isString) as RuleCheck,
Expand Down
2 changes: 2 additions & 0 deletions packages/@stylexjs/stylex/src/types/StyleXCSSTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,7 @@ type OptionalArray<T> = Array<T> | T;
export type SupportedVendorSpecificCSSProperties = Readonly<{
MozOsxFontSmoothing?: null | 'grayscale',
WebkitAppearance?: null | appearance,
WebkitAppRegion?: null | 'drag' | 'no-drag',
WebkitFontSmoothing?: null | 'antialiased',
WebkitTapHighlightColor?: null | color,
}>;
Expand All @@ -969,6 +970,7 @@ export type CSSProperties = Readonly<{
// ...$Exact<SupportedVendorSpecificCSSProperties>, for TypeScript compatibility
MozOsxFontSmoothing?: all | 'grayscale',
WebkitAppearance?: all | appearance,
WebkitAppRegion?: all | 'drag' | 'no-drag',
WebkitFontSmoothing?: all | 'antialiased',
WebkitTapHighlightColor?: all | color,

Expand Down
Loading