Remove old hermes nightly script files (#56752)#56752
Closed
cipolleschi wants to merge 15 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104650744. |
cortinico
approved these changes
May 11, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 11, 2026
Summary: Pull Request resolved: facebook#56752 Delete the old script files that were renamed in prior commits: - scripts/releases/use-hermes-nightly.js (renamed to use-hermes-prebuilt.js) - scripts/try-set-nightly-hermes-compiler.js (renamed to try-set-hermes-compiler-prebuilt.js) These deletions were accidentally omitted from their respective rename commits. Reviewed By: cortinico Differential Revision: D104650744
meta-codesync
Bot
changed the title
cipolleschi
force-pushed
the
export-D104650744
branch
from
7a9f2c2 to
e20a505
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 11, 2026
Summary: Pull Request resolved: facebook#56752 Delete the old script files that were renamed in prior commits: - scripts/releases/use-hermes-nightly.js (renamed to use-hermes-prebuilt.js) - scripts/try-set-nightly-hermes-compiler.js (renamed to try-set-hermes-compiler-prebuilt.js) These deletions were accidentally omitted from their respective rename commits. Reviewed By: cortinico Differential Revision: D104650744
cipolleschi
force-pushed
the
export-D104650744
branch
from
e20a505 to
62bd6ce
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 11, 2026
Summary: Pull Request resolved: facebook#56752 Delete the old script files that were renamed in prior commits: - scripts/releases/use-hermes-nightly.js (renamed to use-hermes-prebuilt.js) - scripts/try-set-nightly-hermes-compiler.js (renamed to try-set-hermes-compiler-prebuilt.js) These deletions were accidentally omitted from their respective rename commits. Reviewed By: cortinico Differential Revision: D104650744
cipolleschi
force-pushed
the
export-D104650744
branch
from
62bd6ce to
8ea5492
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 11, 2026
Summary: Pull Request resolved: facebook#56752 Delete the old script files that were renamed in prior commits: - scripts/releases/use-hermes-nightly.js (renamed to use-hermes-prebuilt.js) - scripts/try-set-nightly-hermes-compiler.js (renamed to try-set-hermes-compiler-prebuilt.js) These deletions were accidentally omitted from their respective rename commits. Reviewed By: cortinico Differential Revision: D104650744
cipolleschi
force-pushed
the
export-D104650744
branch
from
8ea5492 to
75115e6
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 11, 2026
Summary: Pull Request resolved: facebook#56752 Delete the old script files that were renamed in prior commits: - scripts/releases/use-hermes-nightly.js (renamed to use-hermes-prebuilt.js) - scripts/try-set-nightly-hermes-compiler.js (renamed to try-set-hermes-compiler-prebuilt.js) These deletions were accidentally omitted from their respective rename commits. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D104650744
cipolleschi
force-pushed
the
export-D104650744
branch
from
75115e6 to
24fcb79
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 11, 2026
Summary: Pull Request resolved: facebook#56752 Delete the old script files that were renamed in prior commits: - scripts/releases/use-hermes-nightly.js (renamed to use-hermes-prebuilt.js) - scripts/try-set-nightly-hermes-compiler.js (renamed to try-set-hermes-compiler-prebuilt.js) These deletions were accidentally omitted from their respective rename commits. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D104650744
cipolleschi
force-pushed
the
export-D104650744
branch
from
24fcb79 to
940eec1
Compare
…oad the correct commit data. Differential Revision: D104228879
…oad the correct commit data. Differential Revision: D104244582
…56735) Summary: Pull Request resolved: facebook#56735 - Remove `RCT_HERMES_V1_ENABLED` environment variable from `react_native_pods.rb` - Simplify `jsengine.rb` to always use `.hermesversion` tag file - Remove conditional `HERMES_V1_ENABLED=1` preprocessor definition from `utils.rb` - Simplify `hermes-engine.podspec`: always read `HERMES_VERSION_NAME`, use V1 source files, remove legacy inspector subspecs - Simplify `hermes-utils.rb`: remove `hermes_v1_enabled()` function, always use `250829098.0.0-stable` branch, always use `.hermesversion` tag file ## Changelog: [iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods ## Test plan - [x] iOS: `bundle exec pod install` — success - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED Differential Revision: D104247277 Reviewed By: cortinico
Differential Revision: D104380961
Differential Revision: D104381269
Summary: Hermes V1 (Static Hermes) is now always enabled. Remove the isHermesV1 variable and inline its effects: - enableRegenerator is always based on dev mode (was isHermesV1 && dev) - preserveClasses is always true (was isHermesV1) Also update the comments to drop the 'V1' framing. Differential Revision: D104649639
Summary:
The legacy Hermes V0 nightly dist-tag ('nightly') has been removed. This commit
cleans up the ios-prebuild Hermes download logic:
- Remove the 'nightly' sentinel string and getNightlyVersionFromNPM()
- Remove DOWNLOAD_PREBUILT_NIGHTLY_TARBALL source type and downloadPrebuiltNightlyTarball()
- Remove getNightlyTarballUrl() (was fetching from Maven Snapshots for V0 nightlies)
- Rename getLatestV1VersionFromNPM -> getLatestHermesVersionFromNPM
- Update prepare-app-utils.js to use 'latest-v1' instead of 'nightly' for HERMES_VERSION
Differential Revision: D104649632
Summary: Remove the legacy Hermes V0 nightly (Maven Snapshots) download path: - Remove DOWNLOAD_PREBUILT_NIGHTLY_TARBALL source type constant - Remove nightly_artifact_exists(), nightly_tarball_url(), podspec_source_download_prebuilt_nightly_tarball() - Remove net/http and rexml/document requires (only needed for nightly XML parsing) - Rename BUILD_FROM_GITHUB_MAIN -> BUILD_FROM_GITHUB_STABLE_BRANCH (was always targeting the stable V1 branch) - Rename force_build_from_main -> force_build_from_stable_branch - Rename podspec_source_build_from_github_main -> podspec_source_build_from_github_stable_branch - Extract HERMES_STABLE_BRANCH constant so the hardcoded branch is in one place Differential Revision: D104649630
Summary: The functions getLatestHermesNightlyVersion() and updateHermesVersionsToNightly() were misleadingly named: they actually fetch from the 'latest-v1' npm dist-tag, not a 'nightly' tag. Rename them to better reflect what they do: - getLatestHermesNightlyVersion -> getLatestHermesVersion - updateHermesVersionsToNightly -> updateHermesVersionsToPrebuilt Update all call sites in publish-npm.js and publish-npm-test.js. Differential Revision: D104649629
Summary: Rename scripts/releases/use-hermes-nightly.js to scripts/releases/use-hermes-prebuilt.js. The script fetches the latest prebuilt Hermes from the 'latest-v1' npm dist-tag, not a true 'nightly' build. Update: - Script name: use-hermes-nightly.js -> use-hermes-prebuilt.js - Internal log message: 'nightly update' -> 'prebuilt update' - Import: updateHermesVersionsToNightly -> updateHermesVersionsToPrebuilt - CI step names: 'Set nightly Hermes versions' -> 'Set Hermes prebuilt version' - Script path references in test-all.yml, test-ios-helloworld/action.yml, test-ios-rntester/action.yml Differential Revision: D104649633
Summary: Rename scripts/try-set-nightly-hermes-compiler.js to scripts/try-set-hermes-compiler-prebuilt.js. The script sets the hermes-compiler version to the latest prebuilt (latest-v1 on npm), not a nightly build. Update the preinstall script reference in the root package.json. Differential Revision: D104649635
Summary: The use-hermes-nightly boolean input of prebuild-ios-core.yml was misleadingly named. It controls whether to use the latest prebuilt Hermes from npm's latest-v1 dist-tag (not a 'nightly' build). Rename: - prebuild-ios-core.yml input: use-hermes-nightly -> use-hermes-prebuilt - Update description of the input - Update comment to move the TODO note inline - Update callers in nightly.yml and test-all.yml Differential Revision: D104649628
Summary: Update comments that still say 'Hermes V1' as if it is an opt-in feature. Since Hermes (formerly called Hermes V1) is now the only supported engine: - hermes-engine.podspec: drop 'when using Hermes V1' from hermesc note - PathUtils.kt: rewrite the hermesc path comment to drop the 'opted in to Hermes V1' phrasing - hermes-engine/build.gradle.kts: 'Hermes V1 by default...' -> 'Hermes by default...' Differential Revision: D104649634
Summary:
The hermes-utils test used an old-style Hermes git tag
('hermes-2022-04-28-RNv0.69.0-...') as its fixture. Hermes now uses semver
version strings (e.g. '250829098.0.13'). Update the fixture to match the
current format so the test better represents real usage.
Differential Revision: D104649627
Summary: Pull Request resolved: facebook#56752 Delete the old script files that were renamed in prior commits: - scripts/releases/use-hermes-nightly.js (renamed to use-hermes-prebuilt.js) - scripts/try-set-nightly-hermes-compiler.js (renamed to try-set-hermes-compiler-prebuilt.js) These deletions were accidentally omitted from their respective rename commits. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D104650744
cipolleschi
force-pushed
the
export-D104650744
branch
from
940eec1 to
a06ba3e
Compare
|
This pull request has been merged in e2936cb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Delete the old script files that were renamed in prior commits:
These deletions were accidentally omitted from their respective rename commits.
Changelog:
[Internal] -
Reviewed By: cortinico
Differential Revision: D104650744