Repository navigation
test: document TypeForm rejection after inspect.isclass - #5047
Open
asukaminato0721 wants to merge 1 commit into
Open
asukaminato0721 wants to merge 1 commit into
asukaminato0721 wants to merge 1 commit into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D122390360. (Because this pull request was imported automatically, there will not be any future comments.) |
This comment has been minimized.
This comment has been minimized.
asukaminato0721
force-pushed
the
tests-only-pr-4830
branch
from
October 2, 2026 13:34
1a97b9d to
5d7713e
Compare
asukaminato0721
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
asukaminato0721
force-pushed
the
tests-only-pr-4830
branch
from
October 22, 2026 02:48
5d7713e to
79c7a26
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A TypeForm narrowed by inspect.isclass is rejected by isinstance. The test records that incorrect diagnostic and documents that the call should be accepted.
The
testcase!regressions usebug =markers and comments documenting the correct behavior. These are passing tests of known bugs, following the repository test guidance.The complete implementation and regression tests remain in PR #4830. Related issue: #4822.
Validation
Based on upstream
mainatef6de648bce0dc6dcca0a21a9fbb7490f23ecce8.cargo test -p pyrefly --lib -- test_isclass_typeform_class_info— passed.python3 test.py --no-test --no-tensor-shapes --no-conformance --no-jsonschema --no-extension— passed.