Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D120930728. (Because this pull request was imported automatically, there will not be any future comments.) |
jakevdp
force-pushed
the
jax-fft-shape
branch
from
September 20, 2026 23:29
bb9fc7c to
a8357f5
Compare
stroxler
reviewed
Sep 21, 2026
stroxler
requested changes
Sep 21, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Back to you for the question about shared helpers. If you'd rather use helpers that's fine, but my first instinct is that it would make the _shapes code easier to maintain
jakevdp
force-pushed
the
jax-fft-shape
branch
from
September 21, 2026 19:22
a8357f5 to
bdf9eca
Compare
stroxler
approved these changes
Sep 21, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
This pull request has been merged in b23f8e5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate shapes in more cases & avoid overloads in python stubs.