Conversation
|
Hi @Aniketsy! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
# pyrefly: ignore[code] without a space before the bracket
|
@stroxler has imported this pull request. If you are a Meta employee, you can view this in D121014501. (Because this pull request was imported automatically, there will not be any future comments.) |
stroxler
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I'll aim to get a second review and merge it soon.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
grievejia
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary
pyrefly suppresswere adding comments like# pyrefly: ignore [code](with a space), but the docs use# pyrefly: ignore[code](no space). This PR makes both generate the no-space style, as discussed in the issue.comments with a space still work, nothing changes for existing code.
Fixes #4991
Test Plan
cargo test -p pyrefly suppressandcargo test -p pyrefly code_actions.