fix TypeIs[T] with free TypeVar produces no narrowing #4849 - #4867
Closed
asukaminato0721 wants to merge 1 commit into
Closed
asukaminato0721 wants to merge 1 commit into
asukaminato0721 wants to merge 1 commit into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D119300489. (Because this pull request was imported automatically, there will not be any future comments.) |
This comment has been minimized.
This comment has been minimized.
asukaminato0721
force-pushed
the
4849
branch
from
September 10, 2026 11:43
22807fa to
4dc66f4
Compare
This comment has been minimized.
This comment has been minimized.
asukaminato0721
force-pushed
the
4849
branch
from
September 17, 2026 21:03
4dc66f4 to
9c99077
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
Closing this PR because linked issue #4849 was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4849
TypeIs[T]now narrows using T's bound when arguments cannot determine T, while keeping the negative branch conservative.Test Plan
add test