Skip to content

Remove some unnecessary NodeList iterators #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reese merged 1 commit into from
Jun 7, 2026
Merged

Remove some unnecessary NodeList iterators #913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions librubyfmt/src/format_prism.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1462,15 +1462,12 @@ fn format_def_body<'src>(ps: &mut ParserState<'src>, def_node: prism::DefNode<'s
false,
|ps| {
if let Some(body) = def_node.body() {
let mut body_node_list = body.as_statements_node()
let body_node_list = body.as_statements_node()
.expect("Endless methods must have a body, and method definitions are always a Statements node")
.body()
.iter();
let body_expression = body_node_list.next().expect("Endless methods must have exactly one expression in their body");
.body();
debug_assert!(body_node_list.len() == 1, "Expected endless method body to contain exactly one node.");

debug_assert!(body_node_list.next().is_none(), "Expected endless method body to have exactly one node.");

format_node(ps, body_expression);
format_node(ps, body_node_list.first().expect("Expected endless method body to have exactly one node."));
}
},
)
Expand Down Expand Up @@ -3880,7 +3877,7 @@ fn format_conditional_node<'src>(
|ps| format_node(ps, conditional.predicate()),
|ps| {
if let Some(statements) = conditional.statements()
&& let Some(first_statement) = statements.body().iter().next()
&& let Some(first_statement) = statements.body().first()
{
format_node(ps, first_statement);
}
Expand Down