Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a memory leak test detection issue by running the memory leak test in a separate pytest session. The PR modifies test execution to isolate test_memory_leak from other tests, adds debugging output to track memory usage, and simplifies the GitHub Actions workflow configuration.
Key changes:
- Splits test execution into two separate pytest runs: one for
test_memory_leakand one for all other tests - Adds memory usage debugging output to the memory leak detection function
- Simplifies GitHub Actions workflow trigger configuration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| test/test___init__.py | Added debug print statement and changed loop variable name from _ to s for memory tracking |
| makefile | Split all test targets to run memory leak tests separately using -k filters |
| .github/workflows/test.yaml | Simplified workflow triggers and removed conditional test execution logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For unknown reason, running the memory leak test in the same
pytestsession as the other tests breaks the memory leak detection. The solution is to run this test in a separatepytestsession.Also updates the CI to always run the full test suite so we don't accidentally merge another failure of the full tests into
master.