Migrate to new roc#198
Draft
ageron wants to merge 163 commits into
Draft
Conversation
…xercises/practice
Anton-4
reviewed
Jun 22, 2026
Anton-4
reviewed
Jun 22, 2026
Anton-4
reviewed
Jun 22, 2026
Anton-4
reviewed
Jun 22, 2026
Anton-4
reviewed
Jun 22, 2026
Comment on lines
+1
to
+7
| RationalNumbers :: {}.{ | ||
| Rational : { num : I64, den : I64 } | ||
|
|
||
| add : Rational, Rational -> Rational | ||
| add = |{ num: num1, den: den1 }, { num: num2, den: den2 }| { | ||
| { num: num1 * den2 + num2 * den1, den: den1 * den2 }->reduce() | ||
| } |
Contributor
There was a problem hiding this comment.
My feedback from ComplexNumbers applies here as well.
Contributor
Author
There was a problem hiding this comment.
Indeed, I'll update this as well.
Anton-4
reviewed
Jun 22, 2026
…d names with Roc standards such as plus, times, or div_by
…thod names with Roc standards such as plus, times, or div_by
Anton-4
reviewed
Jun 23, 2026
Comment on lines
+2
to
+5
| new : { real : F64, imag : F64 } -> Complex | ||
| new = |{ real, imag }| { | ||
| crash "Please implement the 'new' function" | ||
| } |
Contributor
There was a problem hiding this comment.
Constructors are redundant in Roc, is there a special reason why it was introduced here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the Roc track to the new zig-based Roc compiler and its new syntax.
At the time of writing: