Skip to content

Add a space after < redirects, required by cmd in Wine 10#81

Merged
GroophyLifefor merged 1 commit into
exercism:mainfrom
IsaacG:redir_space
May 14, 2026
Merged

Add a space after < redirects, required by cmd in Wine 10#81
GroophyLifefor merged 1 commit into
exercism:mainfrom
IsaacG:redir_space

Conversation

@IsaacG

@IsaacG IsaacG commented May 14, 2026

Copy link
Copy Markdown
Member

I have no idea why, but cmd in Wine 9 accepts set /p var=<file and cmd in Wine 10 chokes on that, requiring a space in < file. Same exact cmd version. In order to bump the OS version and, by extension, the Wine version, we need to fix the tests here.

See exercism/batch-test-runner#57

@IsaacG IsaacG requested a review from GroophyLifefor May 14, 2026 04:23
@github-actions

Copy link
Copy Markdown

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@BNAndras

Copy link
Copy Markdown
Member

https://gitlab.winehq.org/wine/wine/-/releases/wine-10.0 mentions a rewritten input parser for cmd so possibly that is why this behavior changed.

@GroophyLifefor GroophyLifefor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GroophyLifefor GroophyLifefor merged commit ff09ee6 into exercism:main May 14, 2026
4 checks passed
@IsaacG IsaacG deleted the redir_space branch May 14, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants