Skip to content

[pythagorean-triplet] Add a Jinja test template#856

Merged
kotp merged 1 commit into
exercism:mainfrom
IsaacG:pygen.pythagorean-triplet
Jun 29, 2026
Merged

[pythagorean-triplet] Add a Jinja test template#856
kotp merged 1 commit into
exercism:mainfrom
IsaacG:pygen.pythagorean-triplet

Conversation

@IsaacG

@IsaacG IsaacG commented Jun 29, 2026

Copy link
Copy Markdown
Member

No description provided.

@IsaacG IsaacG added x:module/generator Work on Exercise generators x:module/practice-exercise Work on Practice Exercises x:size/medium Medium amount of work x:rep/medium Medium amount of reputation labels Jun 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@kotp kotp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error message states it... "should be exactly 2 commented skip directive (sic) in pythagorean_triplet.bats"

Might also look at the plural/singular slip there as well.

@IsaacG IsaacG force-pushed the pygen.pythagorean-triplet branch 2 times, most recently from 4f40060 to 37220b5 Compare June 29, 2026 06:27
@IsaacG

IsaacG commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

Error message states it... "should be exactly 2 commented skip directive (sic) in pythagorean_triplet.bats"

Might also look at the plural/singular slip there as well.

Updated

@kotp

kotp commented Jun 29, 2026

Copy link
Copy Markdown
Member

This (The tests, I mean) is running "forever" for me locally.

Processing pythagorean-triplet  
pythagorean_triplet.bats        
 ✓ triplets whose sum is 12     
 ✓ triplets whose sum is 108    
 ✓ triplets whose sum is 1000   
 ✓ no matching triplets for 1001
 ✓ returns all matching triplets
 ✓ several matching triplets    
   triplets for large number 

@IsaacG IsaacG force-pushed the pygen.pythagorean-triplet branch from 37220b5 to ad4219f Compare June 29, 2026 06:52
@IsaacG

IsaacG commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

This (The tests, I mean) is running "forever" for me locally.

I changed the skip-logic in the template but forget to regenerate the test file. It should be better now.

The large test is meant to be skipped.

@kotp kotp merged commit f65d6c0 into exercism:main Jun 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:module/generator Work on Exercise generators x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation x:size/medium Medium amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants