[codex] Wrap generated OpenAPI models behind facade#164
Draft
tkilias wants to merge 1 commit into
Draft
Conversation
ckunki
requested changes
May 12, 2026
| db = None | ||
| try: | ||
| db = self.create_database(name, idle_time=idle_time) | ||
| yield db |
Collaborator
There was a problem hiding this comment.
Also a non-facade data type, I guess.
Will be solved by changing the return type of self.create_database().
Maybe we should add a type hint to this context manager?
Collaborator
There was a problem hiding this comment.
OK, thanks for answering my other comment.
Then only the type hint could be an optional improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace generated OpenAPI model leakage from the handwritten client package with handwritten wrapper types.
What Changed
Why
The previous facade still exposed generated classes from exasol.saas.client.openapi, which kept the generated API surface coupled to the handwritten client layer.
Impact
The handwritten client package now presents a stable wrapper surface instead of forwarding generated models directly.
Validation