Skip to content

Away: the bare AWAY echoing our own return prints no blank line - #338

Open
rubinlinux wants to merge 1 commit into
developfrom
fix/self-away-echo-blank
Open

rubinlinux wants to merge 1 commit into
developfrom
fix/self-away-echo-blank

Conversation

@rubinlinux

Copy link
Copy Markdown
Member

A grey away clock with nothing beside it appeared in the network lobby each time the page came back into view.

Why. A hidden page sends AWAY * (draft/pre-away) and a page that comes back sends a bare AWAY. The server's self away-notify echo of the star was already skipped, but the echo of the bare AWAY became a lobby BACK line with text: "" and self: true. A self away/back line renders only its text (back.vue → ParsedMessage), so it drew the clock and nothing else.

Fix. In handlers/away.ts, the self branch shows an AWAY only when it carries a real away text. That keeps it silent for both * and the bare return. Unchanged: a /away or /back typed here is still confirmed by its 306/305, and another connection of the account setting a real away text ("lunch") still shows. One behaviour change: a /back typed on another device no longer leaves a line here. Before, it left a blank one.

Test. test/irc/presence.ts: "prints nothing for the bare AWAY that echoes its own return, but shows a real away text". It fails on develop (the bare echo adds a line) and passes with the fix. pnpm test passes in full.

🤖 Generated with Claude Code

A hidden page sends AWAY * and a page that comes back sends a bare AWAY.
The self away-notify echo of the star was already silent, but the echo of
the bare AWAY became a lobby BACK line with no text, and a self line shows
only its text: a grey clock beside nothing, once per return to the tab.
The self branch now shows an AWAY only when it carries a real away text;
a /back typed here is still confirmed by its 305.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
github-pages — f810e033 Deployed Nov 21, 2026 by rubinlinux via deploy #1396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant