Repository navigation
Away: the bare AWAY echoing our own return prints no blank line - #338
Open
rubinlinux wants to merge 1 commit into
Open
rubinlinux wants to merge 1 commit into
rubinlinux wants to merge 1 commit into
Conversation
A hidden page sends AWAY * and a page that comes back sends a bare AWAY. The self away-notify echo of the star was already silent, but the echo of the bare AWAY became a lobby BACK line with no text, and a self line shows only its text: a grey clock beside nothing, once per return to the tab. The self branch now shows an AWAY only when it carries a real away text; a /back typed here is still confirmed by its 305. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A grey away clock with nothing beside it appeared in the network lobby each time the page came back into view.
Why. A hidden page sends
AWAY *(draft/pre-away) and a page that comes back sends a bareAWAY. The server's self away-notify echo of the star was already skipped, but the echo of the bareAWAYbecame a lobbyBACKline withtext: ""andself: true. A self away/back line renders only its text (back.vue→ParsedMessage), so it drew the clock and nothing else.Fix. In
handlers/away.ts, the self branch shows anAWAYonly when it carries a real away text. That keeps it silent for both*and the bare return. Unchanged: a/awayor/backtyped here is still confirmed by its 306/305, and another connection of the account setting a real away text ("lunch") still shows. One behaviour change: a/backtyped on another device no longer leaves a line here. Before, it left a blank one.Test.
test/irc/presence.ts: "prints nothing for the bare AWAY that echoes its own return, but shows a real away text". It fails on develop (the bare echo adds a line) and passes with the fix.pnpm testpasses in full.🤖 Generated with Claude Code