Repository navigation
fix(capi): export runtime callbacks in Windows import libraries - #2744
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 0191c8f | Commit Preview URL Branch Preview URL |
Oct 16 2026, 10:33 PM |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Windows C SDK import libraries now include the runtime constructor and all five runtime-call functions. A contract test compares all 33 public header declarations, unmangled Rust exports and Windows definition entries.
Why
The runtime callbacks in #2742 were present in the DLL but missing from the definition file used to generate bashkit.lib. Windows C consumers could not link those six functions.
Before / After
Before: the new inventory regression fails with six missing symbols. After: all 33 declarations match their Rust exports and import-library definitions. The inventory test and complete Python script test suite pass; knowledge, documentation and diff checks pass. Runtime behavior and ABI version are unchanged.
Risk
Low: export manifest and packaging contract test only; no runtime implementation changes.
Checklist