Repository navigation
fix(dd): admit padded buffers before allocation - #2714
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 6a9ffbf | Commit Preview URL Branch Preview URL |
Oct 13 2026, 05:42 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dd conv=syncadmits the complete padded payload before allocation and zero-fill.Checked padding arithmetic enforces the 64 MiB copy cap, and the existing shared
execution budget owns the copy buffer's capacity through output handling. Stdout
cached text uses the same admission boundary. Ordinary
block copies retain padding, count, seek, output and error behavior.
Why
Previously the input cap ran before a plain vector resize. Padding could therefore
exceed the copy cap and bypass the request's live-memory budget.
Before / After
Tiny failing-first fixtures (maximum allocated payload: eight bytes):
Ordinary CLI smoke:
Eight tiny GNU dd comparisons match stdout, stderr and status. VFS tests preserve
seek/notrunc and excl/nocreat failures. Inert version-banner fixtures recognize
GNU dd on Linux and macOS and reject unrelated tools. Compile-only all-feature Clippy, lean
Clippy, formatting, OKF, documentation links, capability/workflow parity, changelog
validation and frozen cargo-vet pass.
Local execution is limited to tiny cases. The existing, unchanged GitHub CI is
explicitly authorized to run full suites. Broad local suites and duplicate
benchmarks are excluded by the batch scope; no CI, tests, caps or hooks changed.
No resource-exhaustion script was executed.
Risk
calls exceeding that budget return a resource-limit error.
this change addresses the padded copy buffer only.
Checklist