Skip to content

chore: merge Marstek Venus E Gen 3.0 template (BC)#31865

Merged
andig merged 2 commits into
masterfrom
chore/marstek-venus-e-gen3
Jul 17, 2026
Merged

chore: merge Marstek Venus E Gen 3.0 template (BC)#31865
andig merged 2 commits into
masterfrom
chore/marstek-venus-e-gen3

Conversation

@andig

@andig andig commented Jul 17, 2026

Copy link
Copy Markdown
Member

Venus E Gen 3.0 only differs from Venus E, E Gen 2.0 and Venus C in the power and soc registers. Both templates are merged, the register map is picked by a new generation param.

  • marstek-venus-e covers marstek-venus-e-v3, so the old template name still resolves
  • generation has no default and is required, since guessing it would silently read the wrong registers. Existing configs have to add it
  • capacity and maxchargepower defaults are unchanged, both templates already used 5.12 kWh / 2500 W

🤖 Generated with Claude Code

/cc @webalexeu

Gen 3.0 only differs in the power and soc registers. It is now a product
of the Venus E template, selected via a generation param.
@andig andig added the devices Specific device support label Jul 17, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider using more descriptive generation values (e.g. "2.0", "3.0" or "gen2", "gen3") instead of plain numeric strings to avoid confusion with other potential revisions.
  • The conditional logic for power and SOC registers is now duplicated inline; you might make this more maintainable by moving generation-specific register maps into a small helper/include instead of sprinkling if eq .generation blocks in the render section.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider using more descriptive generation values (e.g. `"2.0"`, `"3.0"` or `"gen2"`, `"gen3"`) instead of plain numeric strings to avoid confusion with other potential revisions.
- The conditional logic for power and SOC registers is now duplicated inline; you might make this more maintainable by moving generation-specific register maps into a small helper/include instead of sprinkling `if eq .generation` blocks in the render section.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Guessing the generation would silently read the wrong registers.
@andig andig changed the title chore: merge Marstek Venus E Gen 3.0 template chore: merge Marstek Venus E Gen 3.0 template (BC) Jul 17, 2026
@andig
andig enabled auto-merge (squash) July 17, 2026 10:14
@andig
andig merged commit 0cf708a into master Jul 17, 2026
9 checks passed
@andig
andig deleted the chore/marstek-venus-e-gen3 branch July 17, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devices Specific device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant