chore: merge Marstek Venus E Gen 3.0 template (BC)#31865
Merged
Conversation
Gen 3.0 only differs in the power and soc registers. It is now a product of the Venus E template, selected via a generation param.
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider using more descriptive generation values (e.g.
"2.0","3.0"or"gen2","gen3") instead of plain numeric strings to avoid confusion with other potential revisions. - The conditional logic for power and SOC registers is now duplicated inline; you might make this more maintainable by moving generation-specific register maps into a small helper/include instead of sprinkling
if eq .generationblocks in the render section.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider using more descriptive generation values (e.g. `"2.0"`, `"3.0"` or `"gen2"`, `"gen3"`) instead of plain numeric strings to avoid confusion with other potential revisions.
- The conditional logic for power and SOC registers is now duplicated inline; you might make this more maintainable by moving generation-specific register maps into a small helper/include instead of sprinkling `if eq .generation` blocks in the render section.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Guessing the generation would silently read the wrong registers.
andig
enabled auto-merge (squash)
July 17, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Venus E Gen 3.0 only differs from Venus E, E Gen 2.0 and Venus C in the power and soc registers. Both templates are merged, the register map is picked by a new
generationparam.marstek-venus-ecoversmarstek-venus-e-v3, so the old template name still resolvesgenerationhas no default and is required, since guessing it would silently read the wrong registers. Existing configs have to add it🤖 Generated with Claude Code
/cc @webalexeu