chore: merge Marstek Venus A and D templates#31864
Merged
Merged
Conversation
Both templates were identical apart from the capacity and maxchargepower defaults. Venus D is now a product of the Venus A template, the per model values are documented in the param help.
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Given the note that
maxchargepowercan now render as an empty value in battery mode register writes, consider marking it asrequiredor providing a safe fallback to avoid silently misconfigured devices. - With the merged template removing the
capacitydefault, verify that any logic depending on a non-emptycapacityparameter handles the absence appropriately, or consider enforcing it as a required parameter for both Venus A and D.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Given the note that `maxchargepower` can now render as an empty value in battery mode register writes, consider marking it as `required` or providing a safe fallback to avoid silently misconfigured devices.
- With the merged template removing the `capacity` default, verify that any logic depending on a non-empty `capacity` parameter handles the absence appropriately, or consider enforcing it as a required parameter for both Venus A and D.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Both are rendered and no longer carry a default, so an unset value must fail the config instead of rendering empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Venus A and D templates were identical apart from the
capacityandmaxchargepowerdefaults. Venus D is now a product of the Venus A template.marstek-venus-acoversmarstek-venus-d, so existing configs keep workingrequired. yaml configs that relied on the removed defaults now fail withmissing required ...instead of rendering an empty value into the battery mode register writes🤖 Generated with Claude Code
/cc @webalexeu