Skip to content

chore: merge Marstek Venus A and D templates#31864

Merged
andig merged 2 commits into
masterfrom
chore/marstek-venus-ad
Jul 17, 2026
Merged

chore: merge Marstek Venus A and D templates#31864
andig merged 2 commits into
masterfrom
chore/marstek-venus-ad

Conversation

@andig

@andig andig commented Jul 17, 2026

Copy link
Copy Markdown
Member

The Venus A and D templates were identical apart from the capacity and maxchargepower defaults. Venus D is now a product of the Venus A template.

  • marstek-venus-a covers marstek-venus-d, so existing configs keep working
  • the per model values (A 2.12 kWh / 1200 W, D 2.56 kWh / 2200 W) move from the defaults into the param help, since a merged template can only carry one default
  • both params are rendered, so both become required. yaml configs that relied on the removed defaults now fail with missing required ... instead of rendering an empty value into the battery mode register writes

🤖 Generated with Claude Code

/cc @webalexeu

Both templates were identical apart from the capacity and maxchargepower
defaults. Venus D is now a product of the Venus A template, the per model
values are documented in the param help.
@andig andig added the devices Specific device support label Jul 17, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Given the note that maxchargepower can now render as an empty value in battery mode register writes, consider marking it as required or providing a safe fallback to avoid silently misconfigured devices.
  • With the merged template removing the capacity default, verify that any logic depending on a non-empty capacity parameter handles the absence appropriately, or consider enforcing it as a required parameter for both Venus A and D.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Given the note that `maxchargepower` can now render as an empty value in battery mode register writes, consider marking it as `required` or providing a safe fallback to avoid silently misconfigured devices.
- With the merged template removing the `capacity` default, verify that any logic depending on a non-empty `capacity` parameter handles the absence appropriately, or consider enforcing it as a required parameter for both Venus A and D.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Both are rendered and no longer carry a default, so an unset value must
fail the config instead of rendering empty.
@andig
andig merged commit 7a5f935 into master Jul 17, 2026
8 of 9 checks passed
@andig
andig deleted the chore/marstek-venus-ad branch July 17, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devices Specific device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant