Meter (Home Assistant): support return energy entity#31857
Merged
Conversation
Member
|
LGTM |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider guarding the
implement.MeterReturnEnergydecorator with a non-emptycc.ReturnEnergycheck (mirroring theenergyhandling) so that a nilreturnEnergyGis never passed in and behavior is explicit rather than relying onimplement.Mayto handle nil.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider guarding the `implement.MeterReturnEnergy` decorator with a non-empty `cc.ReturnEnergy` check (mirroring the `energy` handling) so that a nil `returnEnergyG` is never passed in and behavior is explicit rather than relying on `implement.May` to handle nil.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
@naltatis könntest Du die Übersetzungen prüfen? Einspeiseenergieentität ist im Allgemeinen Fall immer falsch. |
Member
|
Update: we use "Gegenrichtung" / "reverse direction" in ui and docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #31856
The
homeassistantmeter template only exposed a singleenergyentity, even though its own help text promised it covers both "consumed/produced" energy. There was no way to configure the opposite direction (grid export / battery discharge), becausemeter/homeassistant.gonever decorated the existingapi.MeterReturnEnergycapability.returnEnergyparam to thehomeassistantmeter template, rendered asreturnenergy:ReturnEnergyinmeter/homeassistant.goand decorateimplement.MeterReturnEnergywhen set, mirroring the existingenergy/MeterEnergyhandlingenergy/returnEnergyhelp text to each describe a single direction instead of "consumed/produced"🤖 Generated with Claude Code