fix(op-reth): evict definitively-invalid interop txs on revalidation

[ajsutton]

Three related fixes to the interop txpool revalidation/eviction sweep, all in maintain.rs.

1. Evict on a definitive invalid verdict. The sweep gated eviction on reth's is_bad_transaction() — a peer-penalization predicate that's false for ValidationError(_). A definitive invalid verdict from the interop filter (InvalidEntry/Rejected) was therefore never evicted and stayed buildable until its ~2h cached deadline. Adds a dedicated InvalidCrossTx::is_now_invalid() and uses it in the sweep: evict on a decisive invalid verdict, retain on transient/non-decisive outcomes (quorum miss, timeout, data-unavailable, disagreement) so a flapping or unreachable interop filter can't drain the pool. Failsafe stays handled by the whole-pool eviction; reth's is_bad_transaction() is unchanged.

2. Revalidate non-propagatable interop txs. The sweep iterated pool.pooled_transactions(), which filters out propagate=false txs. Non-propagatable interop txs (Private origin, e.g. from eth_sendRawTransactionConditional) were never revalidated or evicted, yet the builder still selects them via best_transactions() (no propagate filter) — a permanent eviction blind spot. Now scans pool.all_transactions() at all interop sites (failsafe eviction, stale scan, poll_failsafe).

3. Evict all interop txs on reorg. The maintenance loop handled only Commit notifications and silently dropped Reorg. A local-chain reorg can invalidate the initiating message a pooled cross-chain executing tx depends on (and source-chain reorgs are not observable here at all), leaving the dependent tx pooled and buildable. The loop now matches on the event and the Reorg arm evicts all interop txs from the pool. The scan-and-remove logic is extracted into evict_all_interop_txs, shared by the reorg arm, the failsafe path, and poll_failsafe. The OpPool 30s reorg-window admission filter is kept: it suppresses re-admission of interop txs via gossip or block reinjection while the chain settles.

The revalidation sweep is extracted into a testable function; tests drive a real pool against a mock interop-filter endpoint and cover the eviction decision across origin × verdict, plus reorg eviction (incl. a non-propagatable Private-origin tx) and the failsafe-on-commit branch.

[einar-oplabs]

I requested changes because I think it is important we keep the tests super fast.

Let me know if I can help out with something.

[wiz-0f98cca50a]

Wiz Scan Summary

Scanner	Findings
Vulnerabilities	12  5  6
Sensitive Data	-
Secrets	-
IaC Misconfigurations	-
SAST Findings	-
Software Management Findings	-
Total	12  5  6

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

[einar-oplabs]

I think this is a huge improvement 👍

My main point in this round is that we should probably make the type signatures of the InteropFilter as simple as possible. Unless we have a good reason to pass streams and box futures around and track life times of transactions, let's keep it simple.

Let me know if you want me to help with anything.

[einar-oplabs]

I think it is in a good state now. Added some minor points about naming.

[einar-oplabs]

One more thing.