Fix---refresh_token-default-duration#434
Merged
Merged
Conversation
cyrillay
approved these changes
Sep 19, 2025
leoguillaume
requested changes
Sep 19, 2025
| return token_id, token | ||
|
|
||
| async def refresh_token(self, session: AsyncSession, user_id: int, name: str, duration: int) -> Tuple[int, str]: | ||
| async def refresh_token(self, session: AsyncSession, user_id: int, name: str, duration: Optional[int] = None) -> Tuple[int, str]: |
Member
There was a problem hiding this comment.
Il me semble qu'il faut mieux supprimer le paramètre duration et forcer l'expiration à la valeur spécifié en conf (qui peut être none) pour ne pas avoir de comportement inaptemdu (un token qui a duré différente que spécifié en conf). Je ne suis pas sur des implications avec pro-connect. Qu'en penses tu ?
leoguillaume
force-pushed
the
fix---refresh_token-default-duration
branch
from
October 15, 2025 15:16
d5c8873 to
6260a27
Compare
leoguillaume
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reresh_token function signature change breaks compatibility with proconnect login. Since playground token default duration is set in IAM module, set new duration parameter as optional with a default value equals to playground session duration.