Navigation and content-layout redesign#2016
Open
GregorShear wants to merge 2 commits into
Open
Conversation
Squashed rebase of greg/dash/nav onto main. Reworks the app shell: - Collapsible left sidebar nav; user menu, help menu, Agent Skills, and the dark-mode toggle relocated into the sidebar - New content header / PageContainer layout, CompanyMark when collapsed - Theme updates: rounded buttons/icon-buttons, drawer/list overrides, lucide icons (iconoir retained as a dependency) - Per-page create buttons restored on captures/collections/materializations; admin tenant selector kept - Connector settings page removed Reconciled with work merged to main since this branch diverged: the AgentSkills PR (#1975/#1985) and the i18n-deprecation refactor (#2009). ListItemLink keeps main's named-export + deprecated-wrapper pattern and active-route highlighting (useMatch), with a separate onClick prop for action items. The AgentSkills toast retains main's #1985 docs-open hide behavior.
GregorShear
force-pushed
the
greg/dash/nav
branch
from
3129ad7 to
0e58510
Compare
Adopt the agent2 layout shell without the Copilot assistant. - Delete TopBar and drop its grid row from Layout (gridTemplateRows auto 1fr -> 1fr). - Pad the content column with the top strip the top bar used to occupy, so the docs side panel stays top-aligned with the page content and the header lines up with the first sidebar nav item below the logo header. - Move the brand into the sidebar header: full CompanyLogo when expanded, CompanyMark when collapsed, left-anchored so the mark does not jump as the drawer width animates on collapse. - Move the docs open button onto the trailing edge of the PageContainer content header; the header shows the bold page title. UpdateAlert is intentionally orphaned for now. It previously lived in the TopBar, and agent2 only renders it inside the Copilot status bar, which this branch does not include. Keep dash/nav's in-table title removal (EntityTable, Collections); the content header shows the page title, so the in-table title would otherwise duplicate it. Revert the unrelated changes to main: UserAvatar default image, the ExternalLink type decoupling in Error/content, and the icon-context changes in CheckSquare/EditOff. Keep ChipList/Wrapper as-is because its underline removal is coupled to this branch's Theme cleanup (underlineTextSx is no longer exported).
GregorShear
force-pushed
the
greg/dash/nav
branch
from
22b1df0 to
0aa045d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redesigns the app shell around a collapsible left sidebar and a content-area header, and moves app icons from
iconoir-reacttolucide-react.Changes
Navigation
CompanyMarkwhen collapsed), update alert, and docs toggle.ListItemLinktakes route links (link) and action handlers (onClick) as separate props, with active-route highlighting viauseMatch.Layout / theme
Layoutwith a content header inPageContainerthat shows the page title.lucideicon sizing.lucide-reactacross the app.iconoir-reactis kept as a dependency for the remaining usages.Pages
Notes for reviewers
mainand squashed into a single commit. Reconciled with work merged since this branch diverged: the AgentSkills PR (Promote Agent Skills docs on the dashboard #1975 / Fixing zindex for LLM skills toast and hiding when docs are open #1985) and the i18n-deprecation refactor (Deprecate i18n props #2009).ListItemLinkkeeps the named-export + deprecated-wrapper pattern (the react-intl-removal scaffold), and the AgentSkills toast keeps the Fixing zindex for LLM skills toast and hiding when docs are open #1985 "hide when docs panel is open" behavior.iconoir-react→lucide-reactswap.Testing
npm run typecheckandnpm run lintpass.