Update alert subscription UX#2015
Open
kiahna-tucker wants to merge 72 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
The issues directly below are advanced by this PR:
#1960
Changes
1960
Tests
Manually tested
Automated tests
Playwright tests ran locally
Screenshots
NOTE: Code that altered button label styling in the application was merged into this branch after screenshots were taken for this PR. The button labels in the Organization Notifications section of the Settings tab on the Admin page are in title case.
Table
Organization Notifications table
Dialogs
Configure Notification Methods dialog | Initialized
Configure Notification Methods dialog | Subscription summary expanded
Update Notification Methods dialog | Initialized
Update Notification Methods dialog | Subscription summary expanded
Recipients section | No recipients found
Alert Types List Item Interactions
Standard alert type | Deselected
Standard alert type | Deselected | Hovered
Standard alert type | Selected
Standard alert type | Selected | Hovered
System alert type
A list item corresponding to a system alert type does not have a hover state since it cannot be deselected.
Errors
Duplicate subscribed email detected | Subscriber summary expanded
Duplicate subscribed email detected | Subscriber summary collapsed
Multiple email input errors detected | Subscriber summary expanded
Multiple email input errors detected | Subscriber summary collapsed