control-plane: reserve privileged tenant names#3083
Open
jwhartley wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a migration that reserves a set of privileged / role-sounding names in
internal.illegal_tenant_namesso users cannot provision them as tenants:admin,admin1,administrator,root,superuser,support,security,compliance,developers,everyone,internal,system,billing.Why
These names collide conceptually with platform roles and with the
admingrant capability, and make misleading tenant prefixes. Reserving a name also prevents a user from provisioning it and inheriting anyrole_grantsthat were previously created with that name as the subject. This complements an operational cleanup of stale role_grants whose subject was one of these names.Notes
control_plane_api::directives::beta_onboard::tenant_exists) compares case-insensitively, so a single lowercase entry covers all case variants.on conflict do nothing); coexists with any names already inserted directly in an environment.