runtime-next: seed initial connector state as {} to match V1#3081
Open
williamhbaker wants to merge 1 commit into
Open
runtime-next: seed initial connector state as {} to match V1#3081williamhbaker wants to merge 1 commit into
williamhbaker wants to merge 1 commit into
Conversation
A task first published on Runtime-V2 recovers empty bytes for its connector state. Preserve V1 behavior by seeding it as an empty object on the connector-facing requests, since connectors expect state_json to be a JSON document. The capture and derive shards already did this via a local non_empty_state helper; centralize it in crate::patches, drop the duplicate copies, and apply it to the materialize shard's Apply and Open, which previously forwarded empty bytes unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A task first published on Runtime-V2 recovers empty bytes for its connector state. Preserve V1 behavior by seeding it as an empty object on the connector-facing requests, since connectors expect state_json to be a JSON document.
The capture and derive shards already did this via a local non_empty_state helper; centralize it in crate::patches, drop the duplicate copies, and apply it to the materialize shard's Apply and Open, which previously forwarded empty bytes unchanged.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)