First attempt at improving efficiency of powder instrument.#194
Merged
Conversation
On local machine it goes from 215 s to 60 s while preserving chi2 of fit. Improved geometry, set more statistics on thermal moderator, increased split slightly, reduced number of guides in curve
jl-wynen
commented
Jun 16, 2026
| # Update the source focus parameters to match the first guide element | ||
| source.set_parameters( | ||
| dist=source_to_feeder, focus_xw=feeder.xwidth, focus_yh=1.2 * feeder.yheight | ||
| #dist=source_to_psc + 0.05, focus_xw=0.03, focus_yh=0.04 |
Collaborator
Author
There was a problem hiding this comment.
@mads-bertelsen What about this? Should it be removed?
willend
reviewed
Jun 16, 2026
Collaborator
There was a problem hiding this comment.
@jl-wynen FYI a relevant McStasScript feature is incoming: mpi=“auto” will (via underlying mcrun) spawn across whatever (local) pool is available. I believe @mads-bertelsen will push it in a number of days.
Collaborator
Author
There was a problem hiding this comment.
Thanks! Mads already told me. This would indeed be useful.
jl-wynen
force-pushed
the
powder_speed_up
branch
2 times, most recently
from
b70c125 to
d88cc7d
Compare
This reverts commit d88cc7d.
This comes from plotly and is a known issue: jupyter-book/jupyter-book#1950 We had the problem the entire time but it was not flagged by myst. So suppressing it should be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On local machine it goes from 215 s to 60 s while preserving chi2 of fit.
Improved geometry, set more statistics on thermal moderator, increased split slightly, reduced number of guides in curve